From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: mmotm 2011-06-15-16-56 uploaded (mm/page_cgroup.c) Date: Fri, 17 Jun 2011 08:55:55 +0100 Message-ID: <20110617075555.GC5244@suse.de> References: <201106160034.p5G0Y4dr028904@imap1.linux-foundation.org> <20110615214917.a7dce8e6.randy.dunlap@oracle.com> <20110616172819.1e2d325c.kamezawa.hiroyu@jp.fujitsu.com> <20110616103559.GA5244@suse.de> <1308241542.11430.119.camel@nimitz> <20110616165146.GB5244@suse.de> <1308249964.11430.157.camel@nimitz> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: KAMEZAWA Hiroyuki , Randy Dunlap , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org To: Dave Hansen Return-path: Received: from cantor.suse.de ([195.135.220.2]:53397 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922Ab1FQH4I (ORCPT ); Fri, 17 Jun 2011 03:56:08 -0400 Content-Disposition: inline In-Reply-To: <1308249964.11430.157.camel@nimitz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 16, 2011 at 11:46:04AM -0700, Dave Hansen wrote: > On Thu, 2011-06-16 at 17:51 +0100, Mel Gorman wrote: > > No, why was node_start_pfn() and node_end_pfn() defined optionally > > on a per-architecture basis? > > Probably because it started in the NUMA-Q port, and we were still trying > to stay off the radar at that point. It looks like it showed up in > ~2.5.[3-4]?. We didn't know what the heck we were doing back then, and > it probably leaked out from under CONFIG_NUMA/DISCONTIGMEM at some > point. > > Seems like a good thing to consolidate to me. Especially since it's > just a shortcut to the (unconditionally defined) structure member, I > can't see a real justification for needing different definitions. > Great. Thanks Dave. -- Mel Gorman SUSE Labs