From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Date: Wed, 29 Jun 2011 14:09:39 -0400 Message-ID: <20110629180939.GA9934@infradead.org> References: <1309370716-12235-1-git-send-email-josef@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org To: Josef Bacik Return-path: Content-Disposition: inline In-Reply-To: <1309370716-12235-1-git-send-email-josef@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > -int blkdev_fsync(struct file *filp, int datasync) > +int blkdev_fsync(struct file *filp, loff_t start, loff_t end, int datasync) > { > struct inode *bd_inode = filp->f_mapping->host; > struct block_device *bdev = I_BDEV(bd_inode); > @@ -389,14 +389,10 @@ int blkdev_fsync(struct file *filp, int datasync) > * i_mutex and doing so causes performance issues with concurrent > * O_SYNC writers to a block device. > */ > - mutex_unlock(&bd_inode->i_mutex); > - Now that i_mutex on entry isn't held the comment above can be removed.