From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
viro@ZenIV.linux.org.uk, autofs@linux.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Ian Kent <raven@themaw.net>
Subject: Re: [PATCH] VFS: Fix automount for negative autofs dentries
Date: Mon, 11 Jul 2011 11:24:48 -0400 [thread overview]
Message-ID: <20110711152447.GA20501@infradead.org> (raw)
In-Reply-To: <16882.1310393621@redhat.com>
On Mon, Jul 11, 2011 at 03:13:41PM +0100, David Howells wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > would do the same.
>
> But is much less obvious. The LOOKUP_FOLLOW flag is the primary reason for
> this statement. The rest are subordinate and would be wholly irrelevant if
> LOOKUP_FOLLOW was to be removed from the list.
Then keep the LOOKUP_FOLLOW semi-separate as in the original code.
But there's absolutely no reason for the goto spaghetti.
prev parent reply other threads:[~2011-07-11 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 13:20 [PATCH] VFS: Fix automount for negative autofs dentries David Howells
2011-07-11 13:41 ` Christoph Hellwig
2011-07-11 14:13 ` David Howells
2011-07-11 15:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711152447.GA20501@infradead.org \
--to=hch@infradead.org \
--cc=autofs@linux.kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).