From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] writeback: Don't wait for completion in writeback_inodes_sb_nr Date: Tue, 12 Jul 2011 12:34:53 +0200 Message-ID: <20110712103453.GC31226@quack.suse.cz> References: <20110629081155.GA5558@infradead.org> <20110629165714.GF17590@quack.suse.cz> <20110629175534.GA32236@infradead.org> <20110629191518.GA23196@quack.suse.cz> <20110711170042.GE5482@quack.suse.cz> <20110711194835.GI5482@quack.suse.cz> <20110711201157.GA21460@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Curt Wohlgemuth , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, fengguang.wu@intel.com To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20110711201157.GA21460@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon 11-07-11 16:11:57, Christoph Hellwig wrote: > On Mon, Jul 11, 2011 at 09:48:35PM +0200, Jan Kara wrote: > > Well, they're not exactly cheap (journaling filesystems have to force > > transaction commits and wait for them) but that does not really matter. > > The real problem is that to wait for IO completion you need some list of > > inodes you want to wait for and you can currently get such list only from > > superblock. > > All block device inodes sit on blockdev_superblock, we got rid of inodes > without a superblock long time ago. Sure, we can easily iterate also blockdev_superblock. What I meant is that blockdev_superblock will need a special handling since we otherwise ignore pseudo superblocks... Honza -- Jan Kara SUSE Labs, CR