From: Christoph Hellwig <hch@infradead.org>
To: Naohiro Aota <naota@elisp.net>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@tuxera.com>,
Eric Sandeen <sandeen@redhat.com>,
Anton Salikhmetov <alexo@tuxera.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hfsplus: Add record offset check
Date: Thu, 14 Jul 2011 10:53:13 -0400 [thread overview]
Message-ID: <20110714145313.GA16776@infradead.org> (raw)
In-Reply-To: <87mxgku044.fsf@elisp.net>
>
> diff --git a/fs/hfsplus/brec.c b/fs/hfsplus/brec.c
> index 2312de3..5c51d04 100644
> --- a/fs/hfsplus/brec.c
> +++ b/fs/hfsplus/brec.c
> @@ -43,6 +43,10 @@ u16 hfs_brec_keylen(struct hfs_bnode *node, u16 rec)
> node->tree->node_size - (rec + 1) * 2);
> if (!recoff)
> return 0;
> + if (recoff >= node->tree->node_size) {
> + printk(KERN_ERR "hfs: recoff %d too large\n", recoff);
> + return 0;
> + }
As non-obvious as it sounds 0 is indded the canonical error return from
hfs_brec_keylen, so that patch looks good to me. Can you resend it
with a better title and description mentioning better validatation of
the on-disk structures?
next prev parent reply other threads:[~2011-07-14 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 18:46 [PATCH] hfsplus: Add record offset check Naohiro Aota
2011-07-13 3:58 ` Hin-Tak Leung
2011-07-13 6:06 ` Pekka Enberg
2011-07-14 5:06 ` Hin-Tak Leung
2011-07-13 22:20 ` Naohiro Aota
2011-07-14 7:30 ` Pekka Enberg
2011-07-14 8:07 ` Hin-Tak Leung
2011-07-14 14:53 ` Christoph Hellwig [this message]
2011-07-17 22:08 ` [PATCH v2] hfsplus: Add additional range check to handle on-disk corruptions Naohiro Aota
2011-07-18 15:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714145313.GA16776@infradead.org \
--to=hch@infradead.org \
--cc=alexo@tuxera.com \
--cc=hch@tuxera.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naota@elisp.net \
--cc=sandeen@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).