From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@kernel.dk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: fix race in rcu lookup of pruned dentry
Date: Mon, 18 Jul 2011 20:20:38 +0100 [thread overview]
Message-ID: <20110718192038.GG11013@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFw+RwscYUocP0WYWTU=F+Udx+AsjMA0i63-D-y3iZKCTQ@mail.gmail.com>
On Mon, Jul 18, 2011 at 12:08:04PM -0700, Linus Torvalds wrote:
> But I do agree that it's very unlikely to actually cause problems.
> People just don't move mount points around, and the race would seem to
> be ridiculously hard to ever hit even if you tried to create some
> totally artificial load that does nothing but rename mount-points ;)
vfs_rename() will refuse to move mountpoints. Required by POSIX, among
other things...
> But I think I'm on the same page with Hugh that at this point none of
> these issues are even remotely recent, they are basically impossible
> to hit, and the fixes are likely potentially more dangerous than the
> bugs they fix, so I'll release 3.0 without them and just apply the
> fixes (and cc stable) afterwards.
Hmm... Could you pull #for-linus (or #for-linus2, for that matter - same
plus cifs_get_root() fix) first?
next prev parent reply other threads:[~2011-07-18 19:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 21:03 [PATCH] vfs: fix race in rcu lookup of pruned dentry Hugh Dickins
2011-07-17 22:00 ` Linus Torvalds
2011-07-17 22:59 ` Linus Torvalds
2011-07-17 23:26 ` Al Viro
2011-07-17 23:16 ` Al Viro
2011-07-17 23:38 ` Linus Torvalds
2011-07-17 23:47 ` Hugh Dickins
2011-07-18 0:25 ` Al Viro
2011-07-18 1:13 ` Hugh Dickins
2011-07-18 2:08 ` Al Viro
2011-07-18 6:31 ` Linus Torvalds
2011-07-18 14:41 ` Hugh Dickins
2011-07-18 18:11 ` Linus Torvalds
2011-07-18 18:20 ` Al Viro
2011-07-18 19:08 ` Linus Torvalds
2011-07-18 19:20 ` Al Viro [this message]
2011-07-18 19:23 ` Al Viro
2011-07-18 19:34 ` Linus Torvalds
2011-07-18 19:04 ` Hugh Dickins
2011-07-18 19:33 ` Linus Torvalds
2011-07-18 19:47 ` Al Viro
2011-07-18 20:24 ` Linus Torvalds
2011-07-18 21:19 ` Hugh Dickins
2011-07-18 21:42 ` Linus Torvalds
2011-07-18 22:43 ` Hugh Dickins
2011-07-18 23:17 ` Al Viro
2011-07-18 23:21 ` Al Viro
2011-07-18 23:27 ` Linus Torvalds
2011-07-18 23:40 ` Al Viro
2011-07-19 2:07 ` Hugh Dickins
2011-07-19 2:14 ` Linus Torvalds
2011-07-19 2:17 ` Linus Torvalds
2011-07-19 2:23 ` Al Viro
2011-07-19 2:37 ` Chris Ball
2011-07-19 4:41 ` Nicolas Pitre
2011-07-19 2:21 ` Al Viro
2011-07-19 23:45 ` Al Viro
2011-07-19 23:52 ` Al Viro
2011-07-19 23:55 ` Al Viro
2011-07-20 0:47 ` NeilBrown
2011-07-20 1:40 ` Al Viro
2011-07-20 4:52 ` Linus Torvalds
2011-07-19 23:56 ` Linus Torvalds
2011-07-20 0:04 ` Al Viro
2011-07-17 23:53 ` Al Viro
2011-07-17 23:31 ` Hugh Dickins
2011-07-17 23:52 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718192038.GG11013@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).