From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] vfs: fix race in rcu lookup of pruned dentry Date: Mon, 18 Jul 2011 20:20:38 +0100 Message-ID: <20110718192038.GG11013@ZenIV.linux.org.uk> References: <20110717231610.GR11013@ZenIV.linux.org.uk> <20110718002524.GU11013@ZenIV.linux.org.uk> <20110718020818.GW11013@ZenIV.linux.org.uk> <20110718182030.GF11013@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Hugh Dickins , Andrew Morton , Nick Piggin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jul 18, 2011 at 12:08:04PM -0700, Linus Torvalds wrote: > But I do agree that it's very unlikely to actually cause problems. > People just don't move mount points around, and the race would seem to > be ridiculously hard to ever hit even if you tried to create some > totally artificial load that does nothing but rename mount-points ;) vfs_rename() will refuse to move mountpoints. Required by POSIX, among other things... > But I think I'm on the same page with Hugh that at this point none of > these issues are even remotely recent, they are basically impossible > to hit, and the fixes are likely potentially more dangerous than the > bugs they fix, so I'll release 3.0 without them and just apply the > fixes (and cc stable) afterwards. Hmm... Could you pull #for-linus (or #for-linus2, for that matter - same plus cifs_get_root() fix) first?