From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] vfs: fix race in rcu lookup of pruned dentry Date: Tue, 19 Jul 2011 00:21:14 +0100 Message-ID: <20110718232114.GK11013@ZenIV.linux.org.uk> References: <20110718194703.GI11013@ZenIV.linux.org.uk> <20110718231738.GJ11013@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Andrew Morton , Nick Piggin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Hugh Dickins Return-path: Content-Disposition: inline In-Reply-To: <20110718231738.GJ11013@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jul 19, 2011 at 12:17:38AM +0100, Al Viro wrote: > On Mon, Jul 18, 2011 at 03:43:29PM -0700, Hugh Dickins wrote: > > Yes, that looks like THE right fix to me, making others irrelevant. > > But I haven't tested it either, won't begin to do so until tonight. > > And I fear I won't notice if there's any silly little bug in there, > > which forces every fast RCU lookup to go the slow way instead! > > > > Inlined for the benefit of wider scrutiny: > > Looks sane. Applied. I'll wait with pull request until you test it, > but that looks right. Linus, are you OK with me slapping your s-o-b on it?