From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] vfs: fix race in rcu lookup of pruned dentry Date: Tue, 19 Jul 2011 00:40:12 +0100 Message-ID: <20110718234012.GL11013@ZenIV.linux.org.uk> References: <20110718194703.GI11013@ZenIV.linux.org.uk> <20110718231738.GJ11013@ZenIV.linux.org.uk> <20110718232114.GK11013@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Hugh Dickins , Andrew Morton , Nick Piggin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Linus Torvalds Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:33854 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746Ab1GRXkP (ORCPT ); Mon, 18 Jul 2011 19:40:15 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 18, 2011 at 04:27:53PM -0700, Linus Torvalds wrote: > On Mon, Jul 18, 2011 at 4:21 PM, Al Viro wrote: > > > > Linus, are you OK with me slapping your s-o-b on it? > > Yup. > > And it feels so right that I think we should just do it for 3.0. > > I was planning on doing that today, but I guess can delay it too. I'm > at the Intel tech days tomorrow and the day after, but there's WiFi > there and I'll have my laptop. The slightly bigger problem is that it > will move the next merge window even further into my upcoming > vacation, but I was planning on having the laptop with me there too, > so whatever... > > I assume I'll get the cifs_get_root() fix at the same time. Yes. Maybe btrfs get_default_root() one as well, if it survives beating; also a missing i_mutex, along with seriously wrong use of d_splice_alias() (it ignores the return value, for starters, and assumes that inode will not be found in icache once all dentries pointing to it are off the alias list)