From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: swhiteho@redhat.com, linux-fsdevel@vger.kernel.org
Subject: ->quota_sync
Date: Tue, 19 Jul 2011 12:14:06 -0400 [thread overview]
Message-ID: <20110719161406.GA17144@infradead.org> (raw)
Hi Jan,
is there any reason the ->quota_sync operations (which always ends up in
dquot_quota_sync, or gfs2_quota_sync) is called before writing back the
inodes? Given that writeback can perform allocations in filesystem not
using ->page_mkwrite or at least cause delalloc conversions that seems
like the wrong place to me. Even more so fixing the placement means
we could just call dquot_quota_sync from ->sync_fs, similar how XFS
does it's quota writeout, and thus avoiding the duplicate call to
->sync_fs from inside dquot_quota_sync, as well as getting rid of the
abuse of the quotactl ops from VFS code.
next reply other threads:[~2011-07-19 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 16:14 Christoph Hellwig [this message]
2011-07-20 13:31 ` ->quota_sync Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719161406.GA17144@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).