From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: ->quota_sync Date: Tue, 19 Jul 2011 12:14:06 -0400 Message-ID: <20110719161406.GA17144@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: swhiteho@redhat.com, linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:54502 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481Ab1GSQOK (ORCPT ); Tue, 19 Jul 2011 12:14:10 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Jan, is there any reason the ->quota_sync operations (which always ends up in dquot_quota_sync, or gfs2_quota_sync) is called before writing back the inodes? Given that writeback can perform allocations in filesystem not using ->page_mkwrite or at least cause delalloc conversions that seems like the wrong place to me. Even more so fixing the placement means we could just call dquot_quota_sync from ->sync_fs, similar how XFS does it's quota writeout, and thus avoiding the duplicate call to ->sync_fs from inside dquot_quota_sync, as well as getting rid of the abuse of the quotactl ops from VFS code.