linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Andi Kleen <andi@firstfloor.org>, Matthew Wilcox <matthew@wil.cx>,
	Anton Blanchard <anton@samba.org>,
	npiggin@kernel.dk, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [Patch] VFS : mount lock scalability for files systems without mount point   (WAS vfsmount lock issues on very large ppc64 box)
Date: Sat, 23 Jul 2011 09:24:11 -0400	[thread overview]
Message-ID: <20110723132411.GA22183@infradead.org> (raw)
In-Reply-To: <1311294452.2576.18.camel@schen9-DESK>

I think you actually want this done in kern_mount_data, as both
ipc and proc want long-term references as well.  I also suspect with
additional creep of container awareness more internal mounts will switch
to kern_mount_data.  Al, what do you think about simply passing the
private data argument to kern_mount and kill kern_mount_data?  It's not
like the additional argument is going to cause us any pain.


> +struct vfsmount *kern_mount(struct file_system_type *type)
> +{
> +	struct vfsmount *mnt;
> +
> +	mnt = kern_mount_data(type, NULL);
> +	if (!IS_ERR(mnt)) {
> +		/* it is a longterm mount, don't release mnt until */
> +		/* we unmount before file sys is unregistered */

Please use normal kernel comment style, e.g.

	/*
	 * This is a longterm mount, don't release mnt until we umount
	 * it just before unregister_filesystem().
	 */
	
Adding proper kerneldoc comments for the kern_mount/umount function that
explain things in more detail would also be nice.

  reply	other threads:[~2011-07-23 13:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-17  0:50 vfsmount lock issues on very large ppc64 box Anton Blanchard
2011-07-17  1:04 ` Matthew Wilcox
2011-07-17  8:46   ` Andi Kleen
2011-07-18  8:17     ` Eric Dumazet
2011-07-18 15:40       ` Christoph Hellwig
2011-07-18 15:51         ` Al Viro
2011-07-19 16:32           ` [Patch] VFS : mount lock scalability for files systems without mount point (WAS vfsmount lock issues on very large ppc64 box) Tim Chen
2011-07-21 20:40             ` Al Viro
2011-07-22  0:27               ` Tim Chen
2011-07-23 13:24                 ` Christoph Hellwig [this message]
2011-07-25 22:39                   ` Tim Chen
2011-07-25 22:51                     ` Al Viro
2011-07-25 23:22                       ` Tim Chen
2011-07-26  6:00                         ` Eric Dumazet
2011-07-26  8:21                           ` [PATCH] vfs: dont chain pipe/anon/socket on superblock s_inodes list Eric Dumazet
2011-07-26  9:03                             ` Christoph Hellwig
2011-07-26  9:36                               ` Eric Dumazet
2011-07-26  9:42                                 ` Christoph Hellwig
2011-07-26 10:43                                   ` Eric Dumazet
2011-07-26 11:49                                     ` Christoph Hellwig
2011-07-27 15:21                                 ` [PATCH] vfs: avoid taking locks if inode not in lists Eric Dumazet
2011-07-27 17:12                                   ` Andi Kleen
2011-07-27 20:44                                   ` Christoph Hellwig
2011-07-27 20:59                                     ` Andi Kleen
2011-07-27 21:01                                       ` Christoph Hellwig
2011-07-28  4:11                                         ` [PATCH] vfs: conditionally call inode_wb_list_del() Eric Dumazet
2011-07-28  4:41                                     ` [PATCH] vfs: avoid taking locks if inode not in lists Eric Dumazet
2011-07-28  4:55                                     ` [PATCH] vfs: avoid call to inode_lru_list_del() if possible Eric Dumazet
2011-07-18 16:41   ` vfsmount lock issues on very large ppc64 box Tim Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110723132411.GA22183@infradead.org \
    --to=hch@infradead.org \
    --cc=andi@firstfloor.org \
    --cc=anton@samba.org \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=npiggin@kernel.dk \
    --cc=tim.c.chen@linux.intel.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).