From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/4] 9p: do no return 0 from ->check_acl without actually
 checking
Date: Sat, 23 Jul 2011 16:49:22 +0100
Message-ID: <20110723154922.GG24703@ZenIV.linux.org.uk>
References: <20110723153621.GA10832@lst.de>
 <20110723153638.GA10887@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Eric Van Hensbergen <ericvh@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:50340 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752915Ab1GWPtZ (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 23 Jul 2011 11:49:25 -0400
Content-Disposition: inline
In-Reply-To: <20110723153638.GA10887@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jul 23, 2011 at 05:36:38PM +0200, Christoph Hellwig wrote:
> If we do not want to use ACLs we at least need to perform normal Unix
> permission checks.  From the comment I'm not quite sure that's what
> is intended, but if 0p wants to do permission checks entirely on the
> server it needs to do so in ->permission, not in ->check_acl.

I'd like ACK and comments on that from 9p folks...