From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 4/4] fs: take the ACL checks to common code
Date: Sat, 23 Jul 2011 17:15:16 +0100 [thread overview]
Message-ID: <20110723161516.GH24703@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110723160000.GA11196@lst.de>
On Sat, Jul 23, 2011 at 06:00:00PM +0200, Christoph Hellwig wrote:
> On Sat, Jul 23, 2011 at 08:56:12AM -0700, Linus Torvalds wrote:
> > On Sat, Jul 23, 2011 at 8:37 AM, Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > Replace the ->check_acl method with a ->get_acl method that simply reads an
> > > ACL from disk after having a cache miss. ?This means we can replace the ACL
> > > checking boilerplate code with a single implementation in namei.c.
> >
> > Hmm. If we just had a rule for locking (i_mutex?), we could make the
> > cache update be in namei.c too..
>
> Yes, and if we add a ->set_acl we can take most of the existing boilerplate
> code completely into posix_acl.c. I'll see if I can do something like that
> for v3.2.
As for ->set_acl(), how are you going to deal with things like ext3_init_acl(),
where we get transaction handle as argument and pass it down to ext3_set_acl()?
Or the things like e.g. gfs2_set_mode()...
next prev parent reply other threads:[~2011-07-23 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 15:36 [PATCH 0/4] more ACL updates Christoph Hellwig
2011-07-23 15:36 ` [PATCH 1/4] 9p: do no return 0 from ->check_acl without actually checking Christoph Hellwig
2011-07-23 15:49 ` Al Viro
2011-07-25 6:40 ` Aneesh Kumar K.V
2011-07-23 15:36 ` [PATCH 2/4] xfs: cache negative ACLs if there is no attribute fork Christoph Hellwig
2011-07-23 15:37 ` [PATCH 3/4] reiserfs: cache negative ACLs for v1 stat format Christoph Hellwig
2011-07-23 15:37 ` [PATCH 4/4] fs: take the ACL checks to common code Christoph Hellwig
2011-07-23 15:56 ` Linus Torvalds
2011-07-23 16:00 ` Christoph Hellwig
2011-07-23 16:15 ` Al Viro [this message]
2011-07-24 13:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110723161516.GH24703@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).