From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 4/4] fs: take the ACL checks to common code
Date: Sat, 23 Jul 2011 17:15:16 +0100
Message-ID: <20110723161516.GH24703@ZenIV.linux.org.uk>
References: <20110723153621.GA10832@lst.de>
 <20110723153731.GD10887@lst.de>
 <CA+55aFw8D2HsPAw+pxP=F7+FvOi=fYzg7wA7gtX7jz-RWNq_fg@mail.gmail.com>
 <20110723160000.GA11196@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:53842 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752378Ab1GWQPR (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 23 Jul 2011 12:15:17 -0400
Content-Disposition: inline
In-Reply-To: <20110723160000.GA11196@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jul 23, 2011 at 06:00:00PM +0200, Christoph Hellwig wrote:
> On Sat, Jul 23, 2011 at 08:56:12AM -0700, Linus Torvalds wrote:
> > On Sat, Jul 23, 2011 at 8:37 AM, Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > Replace the ->check_acl method with a ->get_acl method that simply reads an
> > > ACL from disk after having a cache miss. ?This means we can replace the ACL
> > > checking boilerplate code with a single implementation in namei.c.
> > 
> > Hmm. If we just had a rule for locking (i_mutex?), we could make the
> > cache update be in namei.c too..
> 
> Yes, and if we add a ->set_acl we can take most of the existing boilerplate
> code completely into posix_acl.c.  I'll see if I can do something like that
> for v3.2.
 
As for ->set_acl(), how are you going to deal with things like ext3_init_acl(),
where we get transaction handle as argument and pass it down to ext3_set_acl()?
Or the things like e.g. gfs2_set_mode()...