From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] vfs: move ACL cache lookup into generic code
Date: Sat, 23 Jul 2011 18:02:16 +0100
Message-ID: <20110723170216.GI24703@ZenIV.linux.org.uk>
References: <alpine.LFD.2.02.1107221023170.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107221038090.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107221932120.27112@i5.linux-foundation.org>
 <20110723032944.GA24703@ZenIV.linux.org.uk>
 <20110723074722.GD24703@ZenIV.linux.org.uk>
 <20110723145037.GA10213@lst.de>
 <20110723153200.GF24703@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:60411 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753071Ab1GWRCT (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 23 Jul 2011 13:02:19 -0400
Content-Disposition: inline
In-Reply-To: <20110723153200.GF24703@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jul 23, 2011 at 04:32:00PM +0100, Al Viro wrote:
> On Sat, Jul 23, 2011 at 04:50:37PM +0200, Christoph Hellwig wrote:
> > On Sat, Jul 23, 2011 at 08:47:22AM +0100, Al Viro wrote:
> > > Anyway, that'll have to wait for tomorrow; I'm going down right now.  This
> > > stuff (plus Tim's "mount lock scalability for internal mounts" patch) is
> > > in #untested in usual place.  Comments/testing/etc. are welcome...
> > 
> > Can't be just pass &inode->i_mode to posix_acl_create for those filesystems
> > that simply write directly into i_mode, instead of keeping it in a local
> > variable?
> 
> umode_t vs. mode_t...

We have some really stunning misuses of mode_t, BTW:
static mode_t
find_smbios_instance_string(struct pci_dev *pdev, char *buf,
                            enum smbios_attr_enum attribute)
{
...
                                        return scnprintf(buf, PAGE_SIZE,
                                                         "%d\n",
...
                                        return scnprintf(buf, PAGE_SIZE,
                                                         "%s\n",
                                                         dmi->name);
...
                        return strlen(dmi->name);
...
        return 0;
}

i.e. that one is misspelled size_t (drivers/pci/pci-label.c).  I don't
like how mode_t and umode_t are mixed up as well...

Why is the latter per-architecture, BTW?  It's unsigned short everywhere
and we'd already got some clowns exposing it in userland ABI (see
include/trace/events/ext4.h).  Is there any good reason for separate
mode_t and umode_t kernel-side?  We use mode_t in some syscall declarations
(not all, BTW - mknod() uses unsigned int), but inside the kernel we
almost immediately lose upper bits on conversions anyway...

And things like ->mkdir() are declare as passing int, treat it as mode_t and
end up storing it in umode_t...  I haven't found any obvious places where
that kind of stuff could cause problems, but that was just a casual look.

umode_t is *old* - it's been introduced in 0.95, back when a bunch of
->i_... got typedefed types.  I never looked into its history and that's
way before my time...