From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] vfs: move ACL cache lookup into generic code
Date: Sat, 23 Jul 2011 19:20:29 +0100
Message-ID: <20110723182029.GJ24703@ZenIV.linux.org.uk>
References: <alpine.LFD.2.02.1107221023170.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107221038090.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107221932120.27112@i5.linux-foundation.org>
 <20110723032944.GA24703@ZenIV.linux.org.uk>
 <20110723074722.GD24703@ZenIV.linux.org.uk>
 <20110723145037.GA10213@lst.de>
 <20110723153200.GF24703@ZenIV.linux.org.uk>
 <20110723170216.GI24703@ZenIV.linux.org.uk>
 <CA+55aFwsLHNJYYV=G5QFFYXHGrvutVw1oSWw_wK=HDX6jYm06A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:33782 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753020Ab1GWSUb (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 23 Jul 2011 14:20:31 -0400
Content-Disposition: inline
In-Reply-To: <CA+55aFwsLHNJYYV=G5QFFYXHGrvutVw1oSWw_wK=HDX6jYm06A@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jul 23, 2011 at 10:31:23AM -0700, Linus Torvalds wrote:

> It would be nice if we
> 
>  (a) got rid of umode_t entirely
> 
>  (b) changed 'mode_t' to the 16-bit traditional unix mode
> 
>  (c) made the users who now use 'mode_t' use the actual size they
> want, since if they actually depend on the higher bits, it shouldn't
> be called mode_t.
> 
> but we'll never do it, because it's such a pain.

Maybe, maybe not...  There's not *that* many of users of either of those.
BTW, what was fchmod(fd, -1) about?  It ends up using current ->i_mode,
but that's not only a Linuxism, it's an undocumented one...  Old one,
too - 0.99.14v, AFAICS.  Looking around on google gave no results (including
usenet search) and there's no changelog for that revision on kernel.org,
AFAICS...