From: Christoph Hellwig <hch@infradead.org>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Josef Bacik <josef@redhat.com>,
linux-fsdevel@vger.kernel.org, hch@infradead.org,
viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
Date: Sun, 24 Jul 2011 07:16:26 -0400 [thread overview]
Message-ID: <20110724111625.GA12658@infradead.org> (raw)
In-Reply-To: <20110723220212.GA1648@x4.trippels.de>
On Sun, Jul 24, 2011 at 12:02:12AM +0200, Markus Trippelsdorf wrote:
> The following patch fixes the problem for me:
Good catch, can you send it with a proper signoff and description?
>
> diff --git a/fs/xfs/linux-2.6/xfs_file.c b/fs/xfs/linux-2.6/xfs_file.c
> index cca00f4..2e23e3d 100644
> --- a/fs/xfs/linux-2.6/xfs_file.c
> +++ b/fs/xfs/linux-2.6/xfs_file.c
> @@ -881,11 +881,14 @@ xfs_file_aio_write(
> /* Handle various SYNC-type writes */
> if ((file->f_flags & O_DSYNC) || IS_SYNC(inode)) {
> loff_t end = pos + ret - 1;
> + int error;
>
> xfs_rw_iunlock(ip, iolock);
> - ret = -xfs_file_fsync(file, pos, end,
> + error = -xfs_file_fsync(file, pos, end,
> (file->f_flags & __O_SYNC) ? 0 : 1);
In addition xfs_file_fsync actually returns a normal negative error,
but that bug already existed before the fsync prototype change. If you
resend the patch, can you fix it as well?
> xfs_rw_ilock(ip, iolock);
> + if (error)
> + ret = error;
> }
next prev parent reply other threads:[~2011-07-24 11:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 18:05 [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Josef Bacik
2011-06-29 18:09 ` Christoph Hellwig
2011-06-29 18:14 ` Josef Bacik
2011-06-29 19:26 ` Jan Kara
2011-07-23 18:09 ` Markus Trippelsdorf
2011-07-23 19:32 ` Markus Trippelsdorf
2011-07-23 20:26 ` Josef Bacik
2011-07-23 20:38 ` Markus Trippelsdorf
2011-07-23 22:02 ` Markus Trippelsdorf
2011-07-24 11:16 ` Christoph Hellwig [this message]
2011-07-24 11:42 ` Christoph Hellwig
2011-07-24 11:54 ` [PATCH] xfs: Fix wrong return value of xfs_file_aio_write Markus Trippelsdorf
2011-07-24 11:57 ` Christoph Hellwig
2011-07-24 11:58 ` [PATCH v2] " Markus Trippelsdorf
2011-07-24 12:03 ` [PATCH] " Markus Trippelsdorf
2011-07-24 12:11 ` Christoph Hellwig
2011-07-26 15:21 ` Alex Elder
2011-07-25 17:38 ` [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Ted Ts'o
-- strict thread matches above, loose matches on Subject: below --
2011-06-28 15:35 Josef Bacik
2011-06-29 16:38 ` Jan Kara
2011-06-29 17:41 ` Josef Bacik
2011-06-29 17:05 ` richard -rw- weinberger
2011-07-04 8:54 ` Steven Whitehouse
2011-07-19 10:24 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110724111625.GA12658@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).