From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] VFS: Cut down inode->i_op->xyz accesses in path walking Date: Tue, 26 Jul 2011 19:41:22 +0100 Message-ID: <20110726184122.GI22133@ZenIV.linux.org.uk> References: <20110726030531.GE22133@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel To: Linus Torvalds Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:41510 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542Ab1GZSlX (ORCPT ); Tue, 26 Jul 2011 14:41:23 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 25, 2011 at 08:23:38PM -0700, Linus Torvalds wrote: > The reason I didn't go any further along that way is that we don't > have any nice atomic operations for small fields like that. The bitops > want a "long" entity, and it becomes just a nightmare to work out bit > positions with big-endian etc. And I definitely didn't want to grow > the inode. Hmm... We still have 19 spare bits in ->i_flags and at least 22 in ->i_state. Do we need to bother with new field at all? ->i_state is unsigned long...