From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/5] vfs: Move noop_backing_dev_info check from sync into
 writeback
Date: Wed, 27 Jul 2011 05:44:53 -0400
Message-ID: <20110727094453.GB11334@infradead.org>
References: <1311719886-1130-1-git-send-email-jack@suse.cz>
 <1311719886-1130-3-git-send-email-jack@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Curt Wohlgemuth <curtw@google.com>,
	Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:39086
	"EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752628Ab1G0Joy (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 27 Jul 2011 05:44:54 -0400
Content-Disposition: inline
In-Reply-To: <1311719886-1130-3-git-send-email-jack@suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Jul 27, 2011 at 12:38:03AM +0200, Jan Kara wrote:
> In principle, a filesystem may want to have ->sync_fs() called during sync(1)
> although it does not have a bdi (i.e. s_bdi is set to noop_backing_dev_info).
> Only writeback code really needs bdi set to something reasonable. So move the
> checks where they are more logical.

Looks good, although as mentioned this would be better done before patch
1.


Reviewed-by: Christoph Hellwig <hch@lst.de>