From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 3/5] quota: Split dquot_quota_sync() to writeback and cache flushing part Date: Wed, 27 Jul 2011 05:45:36 -0400 Message-ID: <20110727094536.GC11334@infradead.org> References: <1311719886-1130-1-git-send-email-jack@suse.cz> <1311719886-1130-4-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Curt Wohlgemuth , Al Viro To: Jan Kara Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:39097 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753926Ab1G0Jph (ORCPT ); Wed, 27 Jul 2011 05:45:37 -0400 Content-Disposition: inline In-Reply-To: <1311719886-1130-4-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jul 27, 2011 at 12:38:04AM +0200, Jan Kara wrote: > Split off part of dquot_quota_sync() which writes dquots into a quota file > to a separate function. In the next patch we will use the function from > filesystems and we do not want to abuse ->quota_sync quotactl callback more > than necessary. I don't know the generic quota code enough to verify that this actually is safe, but the change at least looks good to me from the VFS POW.