From: Christoph Hellwig <hch@infradead.org>
To: Anand Avati <avati@gluster.com>
Cc: Christoph Hellwig <hch@infradead.org>,
miklos@szeredi.hu, fuse-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] fuse: permit O_DIRECT flag in open()
Date: Thu, 28 Jul 2011 07:49:43 -0400 [thread overview]
Message-ID: <20110728114943.GA16704@infradead.org> (raw)
In-Reply-To: <CALmMsH3ECdky8wu3LEd55SJL7fnxda74Y85Y8B7Tq-pVO+XL_g@mail.gmail.com>
On Thu, Jul 28, 2011 at 01:44:08PM +0530, Anand Avati wrote:
> FUSE already has a direct IO implementation (struct file_operations
> fuse_direct_io_file_operation) but is currently set as a file's f_ops
> only based on flags returned from the filesystem server (in the reply
> of an open() call). This patch just lets the filesystem server know a
> userspace application's intention to open a file with O_DIRECT and
> leaves it with the decision to pick direct IO mode on the file (just
> the way it already does before the patch.) There is already a
> framework for direct IO operations and this patch only bridges
> O_DIRECT flag with that framework. Do you still think this is entirely
> incorrect?
Your clearing of the O_DIRECT flag is. The current handling of O_DIRECT
in the VFS is a bit nasty, but if you have an issue with that fix it up
properly instead of piling more hacks on top of it.
next prev parent reply other threads:[~2011-07-28 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 10:56 [PATCH v2 1/2] vfs: pass 'struct file *' as parameter to ->check_flags() methods Anand Avati
[not found] ` <1311764179-20326-1-git-send-email-avati-+FkPdpiNhgJBDgjK7y7TUQ@public.gmane.org>
2011-07-27 10:56 ` [PATCH v2 2/2] fuse: permit O_DIRECT flag in open() Anand Avati
2011-07-27 21:05 ` Christoph Hellwig
2011-07-28 8:14 ` Anand Avati
2011-07-28 11:49 ` Christoph Hellwig [this message]
2011-07-28 18:12 ` Anand Avati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728114943.GA16704@infradead.org \
--to=hch@infradead.org \
--cc=avati@gluster.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).