From: Christoph Hellwig <hch@infradead.org>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfstests: Add support for btrfs in 015
Date: Thu, 28 Jul 2011 16:05:37 -0400 [thread overview]
Message-ID: <20110728200537.GA12758@infradead.org> (raw)
In-Reply-To: <4E31A265.5050909@giantdisaster.de>
On Thu, Jul 28, 2011 at 07:54:45PM +0200, Stefan Behrens wrote:
> To add a 10% tolerance for btrfs was a bad idea.
> Since the output of df(1) is not yet reliable on btrfs volumes while
> data is not flushed to disk, the better implementation would be to
> either let this test fail, or to force a flush to disk before taking
> the output of df(1).
> The latter is what I have implemented now.
I don't think it's correct either. dellalloc blocks should be included
in the statfs output, else it it is pretty pointless. Can you send the
patch to make it generic without that adjustment for now.
next prev parent reply other threads:[~2011-07-28 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 8:27 [PATCH 0/4] xfstests: Add support for btrfs in a couple of xfstests Stefan Behrens
2011-07-28 8:27 ` [PATCH 1/4] xfstests: Add support for btrfs in 062 Stefan Behrens
2011-07-28 8:45 ` Christoph Hellwig
2011-07-28 17:51 ` Stefan Behrens
2011-07-28 8:27 ` [PATCH 2/4] xfstests: Add support for btrfs in 083, 117, 120 and 192 Stefan Behrens
2011-07-28 8:46 ` Christoph Hellwig
2011-07-28 8:28 ` [PATCH 3/4] xfstests: Add support for btrfs in 015 Stefan Behrens
2011-07-28 8:47 ` Christoph Hellwig
2011-07-28 17:54 ` Stefan Behrens
2011-07-28 20:05 ` Christoph Hellwig [this message]
2011-07-28 8:28 ` [PATCH 4/4] xfstests: Add support for btrfs in 079 Stefan Behrens
2011-07-28 8:51 ` Christoph Hellwig
2011-07-29 12:24 ` Stefan Behrens
2011-07-29 12:30 ` Christoph Hellwig
2011-07-29 14:30 ` Stefan Behrens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728200537.GA12758@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).