From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 5/5] vfs: Avoid unnecessary WB_SYNC_NONE writeback during
 sync(1)
Date: Fri, 29 Jul 2011 07:09:04 -0400
Message-ID: <20110729110904.GA8957@infradead.org>
References: <1311719886-1130-1-git-send-email-jack@suse.cz>
 <1311719886-1130-6-git-send-email-jack@suse.cz>
 <20110727095248.GE11334@infradead.org>
 <20110728174203.GF5044@quack.suse.cz>
 <20110728203756.GA28549@infradead.org>
 <CAO81RMZoNQsKWKNtTn-3EfdnCfvMPd0kkC+QYmy9HDGWE2J1Kw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
To: Curt Wohlgemuth <curtw@google.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:40714
	"EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755453Ab1G2LJG (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 29 Jul 2011 07:09:06 -0400
Content-Disposition: inline
In-Reply-To: <CAO81RMZoNQsKWKNtTn-3EfdnCfvMPd0kkC+QYmy9HDGWE2J1Kw@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jul 28, 2011 at 02:20:38PM -0700, Curt Wohlgemuth wrote:
> > for_each_sb {
> > ? ? ? ?sync_inodes_sb();
> > ? ? ? ?sync_fs(wait);
> > ? ? ? ?__sync_blockdev(nowait);
> 
> Do you mean "__sync_blockdev(wait)" here?  'Cause that's what
> __sync_filesystem() does if wait=1.
> 
> I'd have just chalked it up to a typo, but you repeated it everywhere
> below too, and wanted to see if I'm missing something.

It is a typo, and the other errors below are copy & paste instances of
the typo above.