From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
Steven Liu <lingjiujianke@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] xfs: Fix build breakage in xfs_iops.c when CONFIG_FS_POSIX_ACL is not set
Date: Fri, 29 Jul 2011 15:17:52 +0200 [thread overview]
Message-ID: <20110729131752.GA29880@elte.hu> (raw)
In-Reply-To: <20110726093401.GA8334@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Jul 26, 2011 at 11:15:20AM +0200, Markus Trippelsdorf wrote:
> > commit 4e34e719e45, that takes the ACL checks to common code,
> > accidentely broke the build when CONFIG_FS_POSIX_ACL is not set:
> >
> > CC fs/xfs/linux-2.6/xfs_iops.o
> > fs/xfs/linux-2.6/xfs_iops.c:1025:14: error: ???xfs_get_acl??? undeclared here (not in a function)
> >
> > Fix this by declaring xfs_get_acl a static inline function.
>
> Do you have OPTIMIZE_INLINING enabled? In general I dont think we
> can take the address of an inline function, so without this option
> I far the code might not compile, in which case we'll need ifdefs
> around the inode operation assignment in addition to your patch.
FYI, this build bug is still present upstream and triggers rather
frequently in randconfig testing.
Also, according to the timestamps of the guilty commit (4e34e719e45)
it had near zero linux-next testing time before it was pushed
upstream - could we improve on that please?
Thanks,
Ingo
next prev parent reply other threads:[~2011-07-29 13:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 18:56 [git pull] vfs pile 1.5 Al Viro
2011-07-26 3:35 ` Markus Trippelsdorf
2011-07-26 4:52 ` Linus Torvalds
2011-07-26 5:25 ` Stephen Rothwell
2011-07-26 8:21 ` Markus Trippelsdorf
2011-07-26 8:52 ` Steven Liu
2011-07-26 8:58 ` Markus Trippelsdorf
2011-07-26 9:15 ` [PATCH] xfs: Fix build breakage in xfs_iops.c when CONFIG_FS_POSIX_ACL is not set Markus Trippelsdorf
2011-07-26 9:34 ` Christoph Hellwig
2011-07-26 9:47 ` Markus Trippelsdorf
2011-07-26 9:49 ` Christoph Hellwig
2011-07-26 16:12 ` Linus Torvalds
2011-07-29 13:17 ` Ingo Molnar [this message]
2011-07-29 17:56 ` Alex Elder
2011-07-26 15:52 ` [git pull] vfs pile 1.5 Linus Torvalds
2011-07-26 15:59 ` Markus Trippelsdorf
2011-07-26 16:10 ` Linus Torvalds
2011-07-26 16:18 ` Christoph Hellwig
2011-07-26 16:37 ` Linus Torvalds
2011-07-31 3:45 ` Ali Bahar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729131752.GA29880@elte.hu \
--to=mingo@elte.hu \
--cc=hch@infradead.org \
--cc=lingjiujianke@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).