From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 1/4] xfstests: Changed test 062 to be generic for all filesystems Date: Sat, 30 Jul 2011 10:25:30 -0400 Message-ID: <20110730142530.GA31200@infradead.org> References: <95dfa968c48d2bd1095876a6db3369672e76db5f.1311953979.git.sbehrens@giantdisaster.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, xfs@oss.sgi.com To: Stefan Behrens Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:34421 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893Ab1G3OZb (ORCPT ); Sat, 30 Jul 2011 10:25:31 -0400 Content-Disposition: inline In-Reply-To: <95dfa968c48d2bd1095876a6db3369672e76db5f.1311953979.git.sbehrens@giantdisaster.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jul 29, 2011 at 06:06:58PM +0200, Stefan Behrens wrote: > Changed the test 062 to be generic for all filesystems and to be > executed for all filesystems. > Remove output of mkfs since this is specific to mkfs.xfs and now > filtered out. The first three patches look good, but can you please merge them into on. And maybe make the subject description a bit less verbose, e.g. xfstests: make more tests generic Use _scratch_mkfs / _scratch_mkfs_sized instead of _scratch_mkfs_xfs where possible.