From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/4] vfs: ignore error on forced remount Date: Wed, 3 Aug 2011 06:49:14 -0400 Message-ID: <20110803104914.GA32126@infradead.org> References: <1312368521-7911-1-git-send-email-miklos@szeredi.hu> <1312368521-7911-2-git-send-email-miklos@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org, akpm@linux-foundation.org, toshi.okajima@jp.fujitsu.com, mszeredi@suse.cz To: Miklos Szeredi Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:46556 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753482Ab1HCKtU (ORCPT ); Wed, 3 Aug 2011 06:49:20 -0400 Content-Disposition: inline In-Reply-To: <1312368521-7911-2-git-send-email-miklos@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Aug 03, 2011 at 12:48:38PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > On emergency remount we want to force MS_RDONLY on the super block > even if ->remount_fs() failed for some reason. Eww, dangerous territory. At the very least we should log something in the kernel log for thise case.