From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] VFS: Cut down inode->i_op->xyz accesses in path walking
Date: Sun, 7 Aug 2011 07:51:26 +0100
Message-ID: <20110807065126.GW2203@ZenIV.linux.org.uk>
References: <alpine.LFD.2.02.1107221023170.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107221037200.29055@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107222045010.7324@i5.linux-foundation.org>
 <alpine.LFD.2.02.1107251852220.13796@i5.linux-foundation.org>
 <20110726030531.GE22133@ZenIV.linux.org.uk>
 <CA+55aFwNQLXT=4KPsq6xsv-pjk2a=8+mKAe5Jmd4QSnC7-+a3g@mail.gmail.com>
 <CA+55aFwLBtO2czAQmhBWQMnxKYzJd+ER1hzkrz4Gg1+A3cBcbw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:50189 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750747Ab1HGGv2 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 7 Aug 2011 02:51:28 -0400
Content-Disposition: inline
In-Reply-To: <CA+55aFwLBtO2czAQmhBWQMnxKYzJd+ER1hzkrz4Gg1+A3cBcbw@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Aug 06, 2011 at 11:06:18PM -0700, Linus Torvalds wrote:

> My timings still showed roughly a 2% improvement (well 1.8% on the
> "repeat ten times, do the average") but I didn't really do a lot of
> deviation testing. The noise in the numbers is quite noticeable
> between reboots, but I've seen that 1-2% several times over various
> different implementations of the same "try to avoid touching
> inode->i_op->xyz", so I'm pretty convinced it's not just random noise.

Trivial nit: s/do_follow_link/should_follow_link/, I think...