From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] xfstests: fsx: fix fallocate logging Date: Tue, 9 Aug 2011 20:06:58 +1000 Message-ID: <20110809100658.GQ3162@dastard> References: <1312818914-9950-1-git-send-email-josef@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org To: Josef Bacik Return-path: Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:35456 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622Ab1HIKHE (ORCPT ); Tue, 9 Aug 2011 06:07:04 -0400 Content-Disposition: inline In-Reply-To: <1312818914-9950-1-git-send-email-josef@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 08, 2011 at 11:55:14AM -0400, Josef Bacik wrote: > I've been getting segfaults on fsx tests with btrfs because we're using the > wrong values for the logging with fallocate. We were using the numbers 1,2 and > 3 to indicate the type of preallocate we were doing, however we use these to > point to an array, so obviously array[3] for a 3 element array is wrong, so fix > these to do 0,1, and 2. Also spit out of we're using KEEP_SIZE in the log to > make it easier to figure out what's going on. Thanks, > > Signed-off-by: Josef Bacik Already fixed. http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=77c06202484237e26774efbd1774c251b6bef0a9 Cheers, Dave. -- Dave Chinner david@fromorbit.com