From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fsx: fix the hole punching test
Date: Tue, 9 Aug 2011 20:08:12 +1000 [thread overview]
Message-ID: <20110809100812.GR3162@dastard> (raw)
In-Reply-To: <1312819080-10083-1-git-send-email-josef@redhat.com>
On Mon, Aug 08, 2011 at 11:58:00AM -0400, Josef Bacik wrote:
> The test to make sure we support hole punching is just wrong. First it passes
> the mode options into the len argument, and secondly it uses 0 for what I assume
> was meant for the length, which doesn't work right. Also it uses warn instead
> of just normal prt, which will cause xfstests to blow up for no reason. So fix
> the arguments and the error message so that we can actually run xfstests with
> fsx on fs's that don't support hole punching yet. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
Already fixed:
http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=c18bf42de9d5d5fa05025754df1ff63f2147bd12
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2011-08-09 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 15:58 [PATCH] xfstests: fsx: fix the hole punching test Josef Bacik
2011-08-09 10:08 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809100812.GR3162@dastard \
--to=david@fromorbit.com \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).