From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] xfstests: fsx: fix the hole punching test Date: Tue, 9 Aug 2011 20:08:12 +1000 Message-ID: <20110809100812.GR3162@dastard> References: <1312819080-10083-1-git-send-email-josef@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Josef Bacik Return-path: Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:25542 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641Ab1HIKIQ (ORCPT ); Tue, 9 Aug 2011 06:08:16 -0400 Content-Disposition: inline In-Reply-To: <1312819080-10083-1-git-send-email-josef@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 08, 2011 at 11:58:00AM -0400, Josef Bacik wrote: > The test to make sure we support hole punching is just wrong. First it passes > the mode options into the len argument, and secondly it uses 0 for what I assume > was meant for the length, which doesn't work right. Also it uses warn instead > of just normal prt, which will cause xfstests to blow up for no reason. So fix > the arguments and the error message so that we can actually run xfstests with > fsx on fs's that don't support hole punching yet. Thanks, > > Signed-off-by: Josef Bacik Already fixed: http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=c18bf42de9d5d5fa05025754df1ff63f2147bd12 Cheers, Dave. -- Dave Chinner david@fromorbit.com