From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages() Date: Tue, 9 Aug 2011 15:16:22 -0400 Message-ID: <20110809191622.GH6482@redhat.com> References: <20110806084447.388624428@intel.com> <20110806094527.136636891@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Andrea Righi , linux-mm , LKML To: Wu Fengguang Return-path: Content-Disposition: inline In-Reply-To: <20110806094527.136636891@intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Aug 06, 2011 at 04:44:52PM +0800, Wu Fengguang wrote: [..] > -/* > - * task_dirty_limit - scale down dirty throttling threshold for one task > - * > - * task specific dirty limit: > - * > - * dirty -= (dirty/8) * p_{t} > - * > - * To protect light/slow dirtying tasks from heavier/fast ones, we start > - * throttling individual tasks before reaching the bdi dirty limit. > - * Relatively low thresholds will be allocated to heavy dirtiers. So when > - * dirty pages grow large, heavy dirtiers will be throttled first, which will > - * effectively curb the growth of dirty pages. Light dirtiers with high enough > - * dirty threshold may never get throttled. > - */ Hi Fengguang, So we have got rid of the notion of per task dirty limit based on their fraction? What replaces it. I can't see any code which is replacing it. If yes, I am wondering how do you get fairness among tasks which share this bdi. Also wondering what did this patch series to do make sure that tasks share bdi more fairly and get write_bw/N bandwidth. Thanks Vivek -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org