From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages() Date: Wed, 10 Aug 2011 11:26:34 +0800 Message-ID: <20110810032634.GB24486@localhost> References: <20110806084447.388624428@intel.com> <20110806094527.136636891@intel.com> <20110809181543.GG6482@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-fsdevel@vger.kernel.org" , Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Andrea Righi , linux-mm , LKML To: Vivek Goyal Return-path: Content-Disposition: inline In-Reply-To: <20110809181543.GG6482@redhat.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Aug 10, 2011 at 02:15:43AM +0800, Vivek Goyal wrote: > On Sat, Aug 06, 2011 at 04:44:52PM +0800, Wu Fengguang wrote: > > [..] > > - trace_balance_dirty_start(bdi); > > - if (bdi_nr_reclaimable > task_bdi_thresh) { > > - pages_written += writeback_inodes_wb(&bdi->wb, > > - write_chunk); > > - trace_balance_dirty_written(bdi, pages_written); > > - if (pages_written >= write_chunk) > > - break; /* We've done our duty */ > > + if (unlikely(!writeback_in_progress(bdi))) > > + bdi_start_background_writeback(bdi); > > + > > + base_bw = bdi->dirty_ratelimit; > > + bw = bdi_position_ratio(bdi, dirty_thresh, nr_dirty, > > + bdi_thresh, bdi_dirty); > > For the sake of consistency of usage of varibale naming how about using > > pos_ratio = bdi_position_ratio()? OK! > > + if (unlikely(bw == 0)) { > > + pause = MAX_PAUSE; > > + goto pause; > > } > > + bw = (u64)base_bw * bw >> BANDWIDTH_CALC_SHIFT; > > So far bw had pos_ratio as value now it will be replaced with actual > bandwidth as value. It makes code confusing. So using pos_ratio will > help. > > bw = (u64)base_bw * pos_ratio >> BANDWIDTH_CALC_SHIFT; Yeah it makes good sense. I'll change to. rate = (u64)base_rate * pos_ratio >> BANDWIDTH_CALC_SHIFT; Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org