From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org,
Stefan Behrens <sbehrens@giantdisaster.de>
Subject: Re: [PATCH v3 1/2] xfstests: make more tests generic
Date: Wed, 10 Aug 2011 12:33:22 -0400 [thread overview]
Message-ID: <20110810163322.GA30292@infradead.org> (raw)
In-Reply-To: <20110810155214.GE20461@twin.jikos.cz>
On Wed, Aug 10, 2011 at 05:52:14PM +0200, David Sterba wrote:
> there's a hardcoded path for mkfs.btrfs in common.rc:_scratch_mkfs_sized()
>
> 335 btrfs)
> 336 /sbin/mkfs.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV -b $fssize
> 337 ;;
>
> I have a /usr/local/ installation of btrfsprogs from git,
> _scratch_mkfs_sized() was not called for btrfs before.
>
> Possible ways to fix this:
> 1) use /sbin/mkfs -t $FSTYP like _scratch_mkfs, or
> 2) set $MKFS_BTRFS_PROG like for some other filesystems
>
>
> What is preferred?
Please send a patch for variant 2. As soon as we have option using
the generic mkfs wrapper sounds like a good idea. In addition to that
treating btrfs the same way as other filesystems is always good.
next prev parent reply other threads:[~2011-08-10 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 10:31 [PATCH v3 0/2] xfstests: Changed a couple of tests to be generic Stefan Behrens
2011-08-01 10:31 ` [PATCH v3 1/2] xfstests: make more tests generic Stefan Behrens
2011-08-10 15:52 ` David Sterba
2011-08-10 16:33 ` Christoph Hellwig [this message]
2011-08-10 16:38 ` Alex Elder
2011-08-10 16:36 ` Alex Elder
2011-08-10 16:43 ` Christoph Hellwig
2011-08-01 10:31 ` [PATCH v3 2/2] xfstests: make t_immutable and 079 filesystem-agnostic Stefan Behrens
2011-08-01 11:03 ` [PATCH v3 0/2] xfstests: Changed a couple of tests to be generic Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810163322.GA30292@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).