From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: dave@jikos.cz, xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
Stefan Behrens <sbehrens@giantdisaster.de>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 1/2] xfstests: make more tests generic
Date: Wed, 10 Aug 2011 12:43:14 -0400 [thread overview]
Message-ID: <20110810164314.GA2308@infradead.org> (raw)
In-Reply-To: <1312994169.2865.41.camel@doink>
On Wed, Aug 10, 2011 at 11:36:09AM -0500, Alex Elder wrote:
> > Possible ways to fix this:
> > 1) use /sbin/mkfs -t $FSTYP like _scratch_mkfs, or
> > 2) set $MKFS_BTRFS_PROG like for some other filesystems
> >
> >
> > What is preferred?
>
> Whatever works. My personal preference would be option (1)
> if it works, since it's does the generic thing directly
> rather than suggesting something special is needed for
> btrfs. But if that doesn't work, consistency rules so
> MKFS_BTRFS_PROG "like for some other filesystems" is good.
Normally I'd agree with you, but I've run into problems with the
generic mkfs binary, as it parses some options that might otherwise
be left to the filesystem. E.g. it parses -l by itself, which causes
problems when creating an xfs filesystem with an external log.
Note that any filesystem supported by _scratch_mkfs_sized is special;
there is no generic way to specify the size of a filesystem.
next prev parent reply other threads:[~2011-08-10 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 10:31 [PATCH v3 0/2] xfstests: Changed a couple of tests to be generic Stefan Behrens
2011-08-01 10:31 ` [PATCH v3 1/2] xfstests: make more tests generic Stefan Behrens
2011-08-10 15:52 ` David Sterba
2011-08-10 16:33 ` Christoph Hellwig
2011-08-10 16:38 ` Alex Elder
2011-08-10 16:36 ` Alex Elder
2011-08-10 16:43 ` Christoph Hellwig [this message]
2011-08-01 10:31 ` [PATCH v3 2/2] xfstests: make t_immutable and 079 filesystem-agnostic Stefan Behrens
2011-08-01 11:03 ` [PATCH v3 0/2] xfstests: Changed a couple of tests to be generic Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810164314.GA2308@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).