* [PATCH] fs, proc: Report EISDIR when reading sysctl dirs in proc
@ 2011-08-05 11:10 Cyrill Gorcunov
2011-08-15 5:55 ` Cyrill Gorcunov
0 siblings, 1 reply; 5+ messages in thread
From: Cyrill Gorcunov @ 2011-08-05 11:10 UTC (permalink / raw)
To: Alexey Dobriyan, Al Viro; +Cc: Andrew Morton, Pavel Emelyanov, LINUXFS-ML
From: Pavel Emelyanov <xemul@openvz.org>
On reading sysctl dirs we should return -EISDIR instead of -EINVAL.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
fs/proc/proc_sysctl.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6.git/fs/proc/proc_sysctl.c
===================================================================
--- linux-2.6.git.orig/fs/proc/proc_sysctl.c
+++ linux-2.6.git/fs/proc/proc_sysctl.c
@@ -370,6 +370,7 @@ static const struct file_operations proc
};
static const struct file_operations proc_sys_dir_file_operations = {
+ .read = generic_read_dir,
.readdir = proc_sys_readdir,
.llseek = generic_file_llseek,
};
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fs, proc: Report EISDIR when reading sysctl dirs in proc
2011-08-05 11:10 [PATCH] fs, proc: Report EISDIR when reading sysctl dirs in proc Cyrill Gorcunov
@ 2011-08-15 5:55 ` Cyrill Gorcunov
2011-08-24 6:26 ` Pavel Emelyanov
0 siblings, 1 reply; 5+ messages in thread
From: Cyrill Gorcunov @ 2011-08-15 5:55 UTC (permalink / raw)
To: Alexey Dobriyan, Al Viro, Andrew Morton; +Cc: Pavel Emelyanov, LINUXFS-ML
On Fri, Aug 05, 2011 at 03:10:44PM +0400, Cyrill Gorcunov wrote:
> From: Pavel Emelyanov <xemul@openvz.org>
>
> On reading sysctl dirs we should return -EISDIR instead of -EINVAL.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
Ping? Any objections on this patch?
Cyrill
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fs, proc: Report EISDIR when reading sysctl dirs in proc
2011-08-15 5:55 ` Cyrill Gorcunov
@ 2011-08-24 6:26 ` Pavel Emelyanov
2011-08-24 6:30 ` Cyrill Gorcunov
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Emelyanov @ 2011-08-24 6:26 UTC (permalink / raw)
To: Al Viro, Andrew Morton; +Cc: Cyrill Gorcunov, Alexey Dobriyan, LINUXFS-ML
On 08/15/2011 09:55 AM, Cyrill Gorcunov wrote:
> On Fri, Aug 05, 2011 at 03:10:44PM +0400, Cyrill Gorcunov wrote:
>> From: Pavel Emelyanov <xemul@openvz.org>
>>
>> On reading sysctl dirs we should return -EISDIR instead of -EINVAL.
>>
>> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
>> ---
>
> Ping? Any objections on this patch?
Gentlemen, I'm sorry to bother you again, but can you please share your
plans about this fix?
Thanks,
Pavel
> Cyrill
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fs, proc: Report EISDIR when reading sysctl dirs in proc
2011-08-24 6:26 ` Pavel Emelyanov
@ 2011-08-24 6:30 ` Cyrill Gorcunov
2011-08-24 6:36 ` Pavel Emelyanov
0 siblings, 1 reply; 5+ messages in thread
From: Cyrill Gorcunov @ 2011-08-24 6:30 UTC (permalink / raw)
To: Pavel Emelyanov; +Cc: Al Viro, Andrew Morton, Alexey Dobriyan, LINUXFS-ML
On Wed, Aug 24, 2011 at 10:26:36AM +0400, Pavel Emelyanov wrote:
...
> >
> > Ping? Any objections on this patch?
>
> Gentlemen, I'm sorry to bother you again, but can you please share your
> plans about this fix?
>
Andrew has picked it up yesterday. Didn't you get CC?
Cyrill
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fs, proc: Report EISDIR when reading sysctl dirs in proc
2011-08-24 6:30 ` Cyrill Gorcunov
@ 2011-08-24 6:36 ` Pavel Emelyanov
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Emelyanov @ 2011-08-24 6:36 UTC (permalink / raw)
To: Cyrill Gorcunov; +Cc: Al Viro, Andrew Morton, Alexey Dobriyan, LINUXFS-ML
On 08/24/2011 10:30 AM, Cyrill Gorcunov wrote:
> On Wed, Aug 24, 2011 at 10:26:36AM +0400, Pavel Emelyanov wrote:
> ...
>>>
>>> Ping? Any objections on this patch?
>>
>> Gentlemen, I'm sorry to bother you again, but can you please share your
>> plans about this fix?
>>
>
> Andrew has picked it up yesterday. Didn't you get CC?
Not yet :( We've had power outage at Parallels this night, maybe this
is the reason of the delay...
> Cyrill
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-24 6:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-05 11:10 [PATCH] fs, proc: Report EISDIR when reading sysctl dirs in proc Cyrill Gorcunov
2011-08-15 5:55 ` Cyrill Gorcunov
2011-08-24 6:26 ` Pavel Emelyanov
2011-08-24 6:30 ` Cyrill Gorcunov
2011-08-24 6:36 ` Pavel Emelyanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).