linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Curt Wohlgemuth <curtw@google.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Chinner <david@fromorbit.com>,
	Michael Rubin <mrubin@google.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2 v2] writeback: Add writeback stats for pages written
Date: Tue, 16 Aug 2011 20:10:07 +0800	[thread overview]
Message-ID: <20110816121007.GA13391@localhost> (raw)
In-Reply-To: <CAO81RMYmxRiGpEjLGyjKNeNxXg8UJDuVosNdHGKt70gezTjxGw@mail.gmail.com>

Hi Curt,

> > Another question is, how can the display format be script friendly?
> > The current form looks not easily parse-able at least for "cut"..
> 
> I suppose you mean because of the variable number of tokens.  Yeah,
> this can be hard.  Of course, I always just use "awk '{print $NF}'"
> and it works for me :-) .  But I'd be happy to change these to use a
> consistent # of args.

Yes, thank you.  One possible format come to my mind later is to
present the numbers in a 2d table, like this:

                        pages           chunks          works          chunk_kb    work_kbps
balance_dirty_pages     XXXXX             XXXX            XXX              XXXX        XXXXX
background              XXXXX             XXXX            XXX              XXXX        XXXXX
sync                    XXXXX             XXXX            XXX              XXXX        XXXXX
...

The format is not only human friendly and trivial for scripting, but
also permits to add new lines or columns (append only though) without
breaking compatibility.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-08-16 12:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 22:47 [PATCH 1/2 v2] writeback: Add a 'reason' to wb_writeback_work Curt Wohlgemuth
2011-08-12 22:47 ` [PATCH 2/2 v2] writeback: Add writeback stats for pages written Curt Wohlgemuth
2011-08-15 13:48   ` Wu Fengguang
2011-08-15 17:16     ` Curt Wohlgemuth
2011-08-15 18:40       ` Jan Kara
2011-08-15 18:56         ` Curt Wohlgemuth
2011-08-16 13:10           ` Jan Kara
2011-08-16 12:10       ` Wu Fengguang [this message]
2011-08-15 15:03   ` Jan Kara
2011-08-15 17:24     ` Curt Wohlgemuth
2011-08-16 12:26       ` Wu Fengguang
2011-08-15 13:19 ` [PATCH 1/2 v2] writeback: Add a 'reason' to wb_writeback_work Wu Fengguang
2011-09-28 15:02 ` Christoph Hellwig
2011-10-07 15:28   ` Wu Fengguang
2011-10-07 18:07     ` Curt Wohlgemuth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110816121007.GA13391@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=curtw@google.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mrubin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).