From: Josh Boyer <jwboyer@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Oops in minixfs_statfs
Date: Thu, 18 Aug 2011 18:24:10 -0400 [thread overview]
Message-ID: <20110818222409.GT2227@zod.bos.redhat.com> (raw)
In-Reply-To: <20110818211620.GX2203@ZenIV.linux.org.uk>
On Thu, Aug 18, 2011 at 10:16:20PM +0100, Al Viro wrote:
> On Thu, Aug 18, 2011 at 05:13:21PM -0400, Josh Boyer wrote:
>
> > + if (blocks != blocks_needed)
> > + blocks = blocks_needed;
>
> ????
Er.. yeah. That's a left over from before I moved some verification
into fill_super, and then it got simplified to the point of being
utterly stupid. It's been a long day.
I guess I could either just reassign sbi->s_[iz]map_blocks right then
and truly ignore the extra block, or just always pass the calculated
blocks_needed to count_free. Which would you prefer?
josh
prev parent reply other threads:[~2011-08-18 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 16:48 Oops in minixfs_statfs Josh Boyer
2011-08-16 22:20 ` Bob Copeland
2011-08-17 0:31 ` Josh Boyer
2011-08-17 2:18 ` Al Viro
2011-08-17 3:12 ` Bob Copeland
2011-08-17 17:18 ` Josh Boyer
2011-08-18 21:13 ` Josh Boyer
2011-08-18 21:16 ` Al Viro
2011-08-18 22:24 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818222409.GT2227@zod.bos.redhat.com \
--to=jwboyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).