From: Andi Kleen <andi@firstfloor.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andi Kleen <andi@firstfloor.org>,
viro@zeniv.linux.org.uk, hch@infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/7] VFS: Add generic_file_llseek_size
Date: Tue, 23 Aug 2011 18:07:45 +0200 [thread overview]
Message-ID: <20110823160745.GR25996@one.firstfloor.org> (raw)
In-Reply-To: <201108231451.56191.arnd@arndb.de>
On Tue, Aug 23, 2011 at 02:51:56PM +0200, Arnd Bergmann wrote:
> On Monday 22 August 2011, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > Add a generic_file_llseek variant to the VFS that allows passing in
> > the current file size, instead of always using inode->i_size.
> > This can be used to eliminate some cut'n'paste seek code in ext4.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Ah, very nice. I think you can use the same trick to remove duplication
> in default_llseek by always setting the limit to MAX_LFS_FILESIZE.
Not in this patchkit, but some other time perhaps.
-Andi
next prev parent reply other threads:[~2011-08-23 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 20:49 Improve lseek scalability Andi Kleen
2011-08-22 20:49 ` [PATCH 1/7] BTRFS: Fix lseek return value for error Andi Kleen
2011-08-22 20:49 ` [PATCH 2/7] VFS: Do (nearly) lockless generic_file_llseek Andi Kleen
2011-08-22 20:49 ` [PATCH 3/7] VFS: Make generic lseek lockless safe Andi Kleen
2011-08-22 20:49 ` [PATCH 4/7] VFS: Add generic_file_llseek_size Andi Kleen
2011-08-23 0:08 ` Andreas Dilger
2011-08-23 0:10 ` Andi Kleen
2011-08-23 12:51 ` Arnd Bergmann
2011-08-23 16:07 ` Andi Kleen [this message]
2011-08-22 20:49 ` [PATCH 5/7] LSEEK: EXT4: Replace cut'n'pasted llseek code with generic_file_llseek_size Andi Kleen
2011-08-22 20:49 ` [PATCH 6/7] LSEEK: NFS: Drop unnecessary locking in llseek Andi Kleen
2011-08-22 20:49 ` [PATCH 7/7] LSEEK: BTRFS: Avoid i_mutex for SEEK_{CUR,SET,END} Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2011-09-15 23:06 Improve lseek scalability v3 Andi Kleen
2011-09-15 23:06 ` [PATCH 4/7] VFS: Add generic_file_llseek_size Andi Kleen
2011-09-16 15:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823160745.GR25996@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).