From: Wu Fengguang <fengguang.wu@intel.com>
To: <linux-fsdevel@vger.kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Andrea Righi <arighi@develer.com>
Cc: linux-mm <linux-mm@kvack.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 10/10] trace task_io
Date: Fri, 26 Aug 2011 19:38:23 +0800 [thread overview]
Message-ID: <20110826114619.923651827@intel.com> (raw)
In-Reply-To: 20110826113813.895522398@intel.com
[-- Attachment #1: writeback-trace-task-total-dirtied.patch --]
[-- Type: text/plain, Size: 2259 bytes --]
The "write_bytes" curve over time is very handy for viewing the
smoothness and fairness of page dirties for each task.
XXX: It looks not a good fit for writeback traces, shall we create a
include/trace/events/vfs.h for this?
XXX: the other fields of struct task_io_accounting are not dumped.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
include/trace/events/writeback.h | 32 +++++++++++++++++++++++++++++
mm/page-writeback.c | 1
2 files changed, 33 insertions(+)
--- linux-next.orig/include/trace/events/writeback.h 2011-08-22 11:58:21.000000000 +0800
+++ linux-next/include/trace/events/writeback.h 2011-08-22 12:22:38.000000000 +0800
@@ -180,6 +180,38 @@ TRACE_EVENT(writeback_queue_io,
__entry->moved)
);
+TRACE_EVENT(task_io,
+ TP_PROTO(struct task_struct *task),
+ TP_ARGS(task),
+
+ TP_STRUCT__entry(
+ __field(unsigned long long, read_bytes)
+ __field(unsigned long long, write_bytes)
+ __field(unsigned long long, cancelled_write_bytes)
+ ),
+
+ TP_fast_assign(
+ struct task_io_accounting *ioac = &task->ioac;
+
+#ifdef CONFIG_TASK_IO_ACCOUNTING
+ __entry->read_bytes = ioac->read_bytes;
+ __entry->write_bytes = ioac->write_bytes;
+ __entry->cancelled_write_bytes = ioac->cancelled_write_bytes;
+#else
+ __entry->read_bytes = 0;
+ __entry->write_bytes = 0;
+ __entry->cancelled_write_bytes = 0;
+#endif
+ ),
+
+ TP_printk("read=%llu write=%llu cancelled_write=%llu",
+ __entry->read_bytes,
+ __entry->write_bytes,
+ __entry->cancelled_write_bytes
+ )
+);
+
+
TRACE_EVENT(global_dirty_state,
TP_PROTO(unsigned long background_thresh,
--- linux-next.orig/mm/page-writeback.c 2011-08-22 12:10:33.000000000 +0800
+++ linux-next/mm/page-writeback.c 2011-08-22 12:20:33.000000000 +0800
@@ -407,6 +407,7 @@ void global_dirty_limits(unsigned long *
*pbackground = background;
*pdirty = dirty;
trace_global_dirty_state(background, dirty);
+ trace_task_io(current);
}
/**
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-08-26 11:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 11:38 [PATCH 00/10] IO-less dirty throttling v10 Wu Fengguang
2011-08-26 11:38 ` [PATCH 01/10] writeback: account per-bdi accumulated dirtied pages Wu Fengguang
2011-08-26 11:38 ` [PATCH 02/10] writeback: dirty position control Wu Fengguang
2011-08-26 11:38 ` [PATCH 03/10] writeback: dirty rate control Wu Fengguang
2011-08-26 11:38 ` [PATCH 04/10] writeback: stabilize bdi->dirty_ratelimit Wu Fengguang
2011-08-26 11:38 ` [PATCH 05/10] writeback: per task dirty rate limit Wu Fengguang
2011-08-26 12:51 ` Peter Zijlstra
2011-08-26 12:59 ` Wu Fengguang
2011-08-26 11:38 ` [PATCH 06/10] writeback: IO-less balance_dirty_pages() Wu Fengguang
2011-08-26 11:38 ` [PATCH 07/10] writeback: dirty ratelimit - think time compensation Wu Fengguang
2011-08-26 12:05 ` Wu Fengguang
2011-08-26 11:38 ` [PATCH 08/10] writeback: trace balance_dirty_pages Wu Fengguang
2011-08-26 12:07 ` Wu Fengguang
2011-08-26 11:38 ` [PATCH 09/10] writeback: trace dirty_ratelimit Wu Fengguang
2011-08-26 11:38 ` Wu Fengguang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826114619.923651827@intel.com \
--to=fengguang.wu@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).