From: Jan Kara <jack@suse.cz>
To: Curt Wohlgemuth <curtw@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <david@fromorbit.com>,
Michael Rubin <mrubin@google.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3 v3] writeback: Add a 'reason' to wb_writeback_work
Date: Mon, 29 Aug 2011 18:34:25 +0200 [thread overview]
Message-ID: <20110829163425.GF5672@quack.suse.cz> (raw)
In-Reply-To: <20110829162313.GE5672@quack.suse.cz>
On Mon 29-08-11 18:23:13, Jan Kara wrote:
> On Mon 22-08-11 11:38:46, Curt Wohlgemuth wrote:
> > This creates a new 'reason' field in a wb_writeback_work
> > structure, which unambiguously identifies who initiates
> > writeback activity. A 'wb_reason' enumeration has been
> > added to writeback.h, to enumerate the possible reasons.
> >
> > The 'writeback_work_class' and tracepoint event class and
> > 'writeback_queue_io' tracepoints are updated to include the
> > symbolic 'reason' in all trace events.
> >
> > And the 'writeback_inodes_sbXXX' family of routines has had
> > a wb_stats parameter added to them, so callers can specify
> > why writeback is being started.
> Looks good. You can add: Acked-by: Jan Kara <jack@suse.cz>
Oh, one small typo correction:
> > +#define show_work_reason(reason) \
> > + __print_symbolic(reason, \
> > + {WB_REASON_BALANCE_DIRTY, "balance_dirty"}, \
> > + {WB_REASON_BACKGROUND, "background"}, \
> > + {WB_REASON_TRY_TO_FREE_PAGES, "try_to_free_pages"}, \
> > + {WB_REASON_SYNC, "sync"}, \
> > + {WB_REASON_PERIODIC, "periodic"}, \
> > + {WB_REASON_LAPTOP_TIMER, "laptop_timer"}, \
> > + {WB_REASON_FREE_MORE_MEM, "free_more_memory"}, \
> > + {WB_REASON_FS_FREE_SPACE, "FS_free_space"}, \
^^ should be in
non-capital letters?
> > + {WB_REASON_FORKER_THREAD, "forker_thread"} \
> > + )
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-29 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 18:38 [PATCH 1/3] writeback: send work item to queue_io, move_expired_inodes Curt Wohlgemuth
2011-08-22 18:38 ` [PATCH 2/3 v3] writeback: Add a 'reason' to wb_writeback_work Curt Wohlgemuth
2011-08-29 16:23 ` Jan Kara
2011-08-29 16:34 ` Jan Kara [this message]
2011-08-30 18:06 ` Curt Wohlgemuth
2011-08-22 18:38 ` [PATCH 3/3 v3] writeback: Add writeback stats for pages written Curt Wohlgemuth
2011-08-29 16:36 ` Jan Kara
2011-08-30 18:13 ` Curt Wohlgemuth
2011-08-30 22:24 ` Jan Kara
2011-08-29 16:21 ` [PATCH 1/3] writeback: send work item to queue_io, move_expired_inodes Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829163425.GF5672@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=curtw@google.com \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mrubin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).