From: Christoph Hellwig <hch@infradead.org>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
xfs@oss.sgi.com, Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH 3/3] Added test case 259 for the btrfs raid features
Date: Fri, 2 Sep 2011 04:49:41 -0400 [thread overview]
Message-ID: <20110902084941.GB29054@infradead.org> (raw)
In-Reply-To: <4E44351D.4020202@oracle.com>
On Fri, Aug 12, 2011 at 04:01:33AM +0800, Anand Jain wrote:
> Added test case 259 for the btrfs raid features. SCRATCH_DEV_POOL must
> be set to 2 or more disks.
Any chance you can document how SCRATCH_DEV_POOL is supposed to be
used in the README file? An addition patch is fine, no need to update
the existing ones. Also is there a chance you could allow setting
only SCRATCH_DEV_POOL for btrfs, and derive SCRATCH_DEV for that as an
additional step?
> +# arg 1 remove/add
> +# arg 2 /dev/sdx or return of devmgt resply
> +_devmgt()
> +{
> + local x
> + local d
> +
> + if [ $1 == "remove" ]; then
> + d=`echo $2|cut -d"/" -f3`
> + x=`ls -l /sys/class/block/${d} | cut -d "/" -f12 | sed 's/:/ /g'`
> + echo "scsi remove-single-device ${x}" > /proc/scsi/scsi || _fail
> "Remove disk failed"
> + DEVHTL=${x}
> + else
> + echo "scsi add-single-device ${2}" > /proc/scsi/scsi || _fail
> "Add disk failed"
> + fi
> +}
Please use the sysfs interface instead of the deprecated /proc/scsi/scsi
interface. I would also suggest to split this routine into two for
removing and adding, and move them to the common helper library, so it
could be used for other tests.
> +# we need this to test removing a dev from the system
> +_require_proc_scsi()
> +{
> + [ -e /proc/scsi/scsi ] || _notrun "/proc/scsi/scsi is not present"
> +}
The _require need really is that the device you want to work on is a
SCSI device.
next prev parent reply other threads:[~2011-09-02 8:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 7:59 [PATCH] snapshot, defragment and raid test cases for btrfs Anand Jain
2011-08-05 13:53 ` Amir Goldstein
2011-08-05 15:40 ` Greg Freemyer
2011-08-05 21:42 ` Greg Freemyer
2011-08-06 14:06 ` Dave Chinner
2011-08-11 19:52 ` Anand Jain
2011-08-11 20:01 ` [PATCH 1/3] Added test case 257 for btrfs extended snapshot tests Anand Jain
2011-08-15 7:52 ` [PATCH v2 " Anand Jain
2011-09-02 8:45 ` [PATCH " Christoph Hellwig
2011-08-11 20:01 ` [PATCH 2/3] Added test case 258 for btrfs defragmentation Anand Jain
2011-08-11 20:01 ` [PATCH 3/3] Added test case 259 for the btrfs raid features Anand Jain
2011-09-02 8:49 ` Christoph Hellwig [this message]
2011-10-03 11:25 ` Anand Jain
2011-10-10 9:58 ` [PATCH] Changes to received review comments Anand Jain
2011-10-10 11:21 ` Christoph Hellwig
2011-10-11 11:25 ` Anand Jain
2011-10-11 11:26 ` [PATCH 1/3] 263: Functional test case for the btrfs snapshot Anand Jain
2011-10-11 11:38 ` David Sterba
2011-10-11 11:42 ` Christoph Hellwig
2011-10-11 11:47 ` David Sterba
2011-10-11 11:27 ` [PATCH 2/3] 264: Functional test case for the btrfs de-fragmentation Anand Jain
2011-10-11 11:28 ` [PATCH 3/3] 265: Functional test case for the btrfs raid operations Anand Jain
2011-10-12 4:52 ` [PATCH 0/3] xfstest patch Anand Jain
2011-10-12 4:52 ` [PATCH 1/3] 263: Functional test case for the btrfs snapshot Anand Jain
2011-10-13 0:56 ` Dave Chinner
2011-10-18 6:28 ` [PATCH 0/3] xfstests patches Anand Jain
2011-10-18 6:28 ` [PATCH 1/3] 264: Functional test case for the btrfs snapshot Anand Jain
2011-10-19 9:42 ` Christoph Hellwig
2011-10-20 15:31 ` Anand Jain
2011-10-18 6:28 ` [PATCH 2/3] 265: Functional test case for the btrfs de-fragmentation Anand Jain
2011-10-19 9:43 ` Christoph Hellwig
2011-10-20 15:32 ` Anand Jain
2011-10-18 6:28 ` [PATCH 3/3] 266: Functional test case for the btrfs raid operations Anand Jain
2011-10-19 9:45 ` Christoph Hellwig
2011-10-20 15:32 ` Anand Jain
2011-10-20 15:41 ` [PATCH 0/5] xfstests enhancement and bug fix Anand Jain
2011-10-20 15:41 ` [PATCH 1/5] fill files with random data Anand Jain
2011-10-25 11:35 ` Christoph Hellwig
2011-10-20 15:41 ` [PATCH 2/5] Added SCRATCH_DEV_POOL to specify multiple disks for the btrfs RAID Anand Jain
2011-10-25 11:36 ` Christoph Hellwig
2011-10-20 15:41 ` [PATCH 3/5] 264: Functional test case for the btrfs snapshot Anand Jain
2011-10-25 11:36 ` Christoph Hellwig
2011-10-20 15:41 ` [PATCH 4/5] 265: Functional test case for the btrfs raid operations Anand Jain
2011-10-25 11:37 ` Christoph Hellwig
2011-10-20 15:41 ` [PATCH 5/5] _populate_fs should use OPTIND when getopts is used Anand Jain
2011-10-25 11:37 ` Christoph Hellwig
2011-10-12 4:52 ` [PATCH 2/3] 264: Functional test case for the btrfs de-fragmentation Anand Jain
2011-10-12 4:52 ` [PATCH 3/3] 265: Functional test case for the btrfs raid operations Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902084941.GB29054@infradead.org \
--to=hch@infradead.org \
--cc=Anand.Jain@oracle.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).