From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 11/13] dcache: use a dispose list in select_parent Date: Mon, 5 Sep 2011 05:42:52 -0400 Message-ID: <20110905094252.GA28967@infradead.org> References: <1314089786-20535-1-git-send-email-david@fromorbit.com> <1314089786-20535-12-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, khlebnikov@openvz.org To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <1314089786-20535-12-git-send-email-david@fromorbit.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org > -/** > * shrink_dcache_sb - shrink dcache for a superblock > * @sb: superblock > * > @@ -1073,7 +1054,7 @@ EXPORT_SYMBOL(have_submounts); > * drop the lock and return early due to latency > * constraints. > */ > -static long select_parent(struct dentry * parent) > +static long select_parent(struct dentry *parent, struct list_head *dispose) Btw, the function header comment above select_parent is entirely incorrect after your changes. Also I'd suggest folding select_parent into shrink_dcache_parent as the split doesn't make a whole lot of sense any more. Maybe factoring it at a different level would make sense, though. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org