From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org
Subject: Re: quota tests
Date: Tue, 6 Sep 2011 11:15:05 -0400 [thread overview]
Message-ID: <20110906151505.GA7213@infradead.org> (raw)
In-Reply-To: <20110906151236.GG23747@quack.suse.cz>
On Tue, Sep 06, 2011 at 05:12:36PM +0200, Jan Kara wrote:
> To verify reclaim behavior for VFS quotas, we could pull quota structures
> in memory using GETQUOTA and then apply memory pressure to have them
> reclaimed. If we also want to combine this with updates to those structures
> because of allocations it gets more complicated. We'd have to do IO for
> several different users in sequence under memory pressure so that all
> inodes of one user get pushed out of memory and quota structure is thus
> freed for reclaim as well.
>
> As for racing lookups / other quota operations - these are not that
> much interesting for VFS quotas because
> a) once quota structure is created, it's position on disk is fixed
> b) any operation on quota file that does more than update accounting
> information in a structure is protected by per quota-file mutex.
> c) in memory operations with quota structures are protected by one global
> spinlock
It's fairly similar for XFS - but we still have code to e.g. retry the
lookup after we did a memory allocation in both quota implementation.
I just change the way the one in XFS worked, so I'm looking for a way
to actually test that path.
next prev parent reply other threads:[~2011-09-06 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 12:21 quota tests Christoph Hellwig
2011-09-06 14:43 ` Jan Kara
2011-09-06 14:50 ` Christoph Hellwig
2011-09-06 15:12 ` Jan Kara
2011-09-06 15:15 ` Christoph Hellwig [this message]
2011-09-06 14:50 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906151505.GA7213@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).