From: Josh Boyer <jwboyer@redhat.com>
To: Nelson Elhage <nelhage@nelhage.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Davide Libenzi <davidel@xmailserver.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Paul Bolle <pebolle@tiscali.nl>,
stable@kernel.org
Subject: Re: [PATCH] epoll: Fix spurious lockdep warnings
Date: Wed, 7 Sep 2011 20:04:29 -0400 [thread overview]
Message-ID: <20110908000429.GK10700@zod.bos.redhat.com> (raw)
In-Reply-To: <1312913515-432-1-git-send-email-nelhage@nelhage.com>
On Tue, Aug 09, 2011 at 02:11:55PM -0400, Nelson Elhage wrote:
> epoll can acquire recursively acquire ep->mtx on multiple "struct
> eventpoll"s at once in the case where one epoll fd is monitoring
> another epoll fd. This is perfectly OK, since we're careful about the
> lock ordering, but it causes spurious lockdep warnings. Annotate the
> recursion using mutex_lock_nested, and add a comment explaining the
> nesting rules for good measure.
>
> Recent versions of systemd are triggering this, and it can also be
> demonstrated with the following trivial test program:
>
> --------------------8<--------------------
>
> int main(void) {
> int e1, e2;
> struct epoll_event evt = {
> .events = EPOLLIN
> };
>
> e1 = epoll_create1(0);
> e2 = epoll_create1(0);
> epoll_ctl(e1, EPOLL_CTL_ADD, e2, &evt);
> return 0;
> }
> --------------------8<--------------------
>
> Cc: stable@kernel.org
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Tested-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Nelson Elhage <nelhage@nelhage.com>
Any progress on this heading upstream?
josh
next prev parent reply other threads:[~2011-09-08 0:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 18:11 [PATCH] epoll: Fix spurious lockdep warnings Nelson Elhage
2011-09-08 0:04 ` Josh Boyer [this message]
2011-09-13 20:22 ` Jason Baron
2011-09-13 21:16 ` Andrew Morton
2011-09-15 15:15 ` Jason Baron
-- strict thread matches above, loose matches on Subject: below --
2011-07-30 21:25 recursive locking: epoll Nelson Elhage
2011-07-30 22:30 ` [PATCH] epoll: Fix spurious lockdep warnings Nelson Elhage
2011-07-31 15:06 ` Paul Bolle
2011-07-31 15:16 ` Nelson Elhage
2011-07-31 21:39 ` Paul Bolle
2011-07-31 21:36 ` Paul Bolle
2011-07-31 21:48 ` Paul Bolle
2011-08-09 15:11 ` Josh Boyer
2011-08-09 17:36 ` Nelson Elhage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908000429.GK10700@zod.bos.redhat.com \
--to=jwboyer@redhat.com \
--cc=davidel@xmailserver.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nelhage@nelhage.com \
--cc=pebolle@tiscali.nl \
--cc=stable@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).