From: Christoph Hellwig <hch@infradead.org>
To: Shawn Bohrer <sbohrer@rgmadvisors.com>
Cc: "Darrick J. Wong" <djwong@us.ibm.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: Stalls during writeback for mmaped I/O on XFS in 3.0
Date: Thu, 15 Sep 2011 10:55:57 -0400 [thread overview]
Message-ID: <20110915145556.GA19902@infradead.org> (raw)
In-Reply-To: <20110915144755.GB2235@BohrerMBP.rgmadvisors.com>
On Thu, Sep 15, 2011 at 09:47:55AM -0500, Shawn Bohrer wrote:
> I've got a workload that is latency sensitive that writes data to a
> memory mapped file on XFS. With the 3.0 kernel I'm seeing stalls of
> up to 100ms that occur during writeback that we did not see with older
> kernels. I've traced the stalls and it looks like they are blocking
> on wait_on_page_writeback() introduced in
> d76ee18a8551e33ad7dbd55cac38bc7b094f3abb "fs: block_page_mkwrite
> should wait for writeback to finish"
>
> Reading the commit description doesn't really explain to me why this
> change was needed.
It it there to avoid pages beeing modified while they are under
writeback, which defeats various checksumming like DIF/DIX, the iscsi
CRCs, or even just the RAID parity calculations. All of these either
failed before, or had to work around it by copying all data was
written.
If you don't use any of these you can remove the call and things
will work like they did before.
next prev parent reply other threads:[~2011-09-15 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 14:47 Stalls during writeback for mmaped I/O on XFS in 3.0 Shawn Bohrer
2011-09-15 14:55 ` Christoph Hellwig [this message]
2011-09-15 15:47 ` Shawn Bohrer
2011-09-16 0:25 ` Darrick J. Wong
2011-09-16 16:32 ` Shawn Bohrer
2011-09-20 16:30 ` Christoph Hellwig
2011-09-20 18:42 ` Shawn Bohrer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915145556.GA19902@infradead.org \
--to=hch@infradead.org \
--cc=djwong@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sbohrer@rgmadvisors.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).