From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] xip: export xip_file_fault Date: Sat, 17 Sep 2011 09:53:47 -0400 Message-ID: <20110917135346.GA31551@infradead.org> References: <4E749003.30909@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux FS Devel , Linux Kernel To: Marco Stornelli Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:42379 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832Ab1IQNxs (ORCPT ); Sat, 17 Sep 2011 09:53:48 -0400 Content-Disposition: inline In-Reply-To: <4E749003.30909@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Sep 17, 2011 at 02:18:11PM +0200, Marco Stornelli wrote: > From: Marco Stornelli > > There aren't sufficient sync points for a fs for xip operations. In > particular for the mmap case. It can be not sufficient to lock/unlock > to do some operation inside get_xip_mem callback. For xip_file_read > it's really easy to write a fs specific wrapper, xip_file_write hold > i_mutex so no problem. With this patch it's possible to reuse the > generic xip_file_fault, using a wrapper function in a fs, without to > reinvent the wheel. As usual please send patches to add exports only while adding callers for it.