From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH v3] fs/minix: Verify bitmap block counts before mounting Date: Thu, 29 Sep 2011 19:51:32 +0100 Message-ID: <20110929185132.GM2203@ZenIV.linux.org.uk> References: <20110819185025.GD2270@zod.bos.redhat.com> <20110929183818.GI16720@zod.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Josh Boyer Return-path: Content-Disposition: inline In-Reply-To: <20110929183818.GI16720@zod.bos.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Sep 29, 2011 at 02:38:18PM -0400, Josh Boyer wrote: > On Fri, Aug 19, 2011 at 02:50:25PM -0400, Josh Boyer wrote: > > Newer versions of MINIX can create filesystems that allocate an extra > > bitmap block. Mounting of this succeeds, but doing a statfs call will > > result in an oops in count_free because of a negative number being used > > for the bh index. > > > > Avoid this by verifying the number of allocated blocks at mount time, > > erroring out if there are not enough and make statfs ignore the extras > > if there are too many. > > > > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=18792 > > > > Signed-off-by: Josh Boyer > > Al, did this ever get queued up to send to Linus? Sits in my tree, waiting for kernel.org to come back, with obvious followup on top of it... commit 2a0b3282ff528af4c0824c16d99c62a53d029720 Author: Al Viro Date: Fri Aug 26 22:38:50 2011 -0400 minixfs: kill manual hweight(), simplify Signed-off-by: Al Viro commit b928f2ccce51ffd666e4238e8c166dfeb0069c28 Author: Josh Boyer Date: Fri Aug 19 14:50:26 2011 -0400 fs/minix: Verify bitmap block counts before mounting