From: Christoph Hellwig <hch@infradead.org>
To: Sage Weil <sage@newdream.net>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, viro@ZenIV.linux.org.uk,
ceph-devel@vger.kernel.org, rwheeler@redhat.com,
linux-kernel@vger.kernel.org, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] vfs: add d_prune dentry operation
Date: Sun, 9 Oct 2011 09:21:55 -0400 [thread overview]
Message-ID: <20111009132155.GA5920@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1110061507550.29500@cobra.newdream.net>
On Thu, Oct 06, 2011 at 03:20:37PM -0700, Sage Weil wrote:
> > It also seem like it basically should not be be opencoded but in a
> > wrapper around dentry_lru_del for all cases but the lazy removal from
> > LRU in case that is referenced, with some comments explaining the whole
> > thing.
>
> Yeah, that's a bit better. There are four dentry_lru_del() callers, two
> where we there is a reference, and two where we want to ->d_prune too.
>
> How does the below look?
This looks much better.
It will clash a bit with Dave's dcache series that were part of his
shrinker/lru series, which I really hope he is going to resumit for
3.2 (at least the dcache cleanup parts).
Al, any progress on getting the current VFS queue up somewhere for
review?
next prev parent reply other threads:[~2011-10-09 13:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 4:26 [PATCH] d_prune dentry_operation Sage Weil
2011-10-06 4:26 ` [PATCH] vfs: add d_prune dentry operation Sage Weil
2011-10-06 21:21 ` Christoph Hellwig
2011-10-06 22:20 ` Sage Weil
2011-10-09 13:21 ` Christoph Hellwig [this message]
2011-10-10 5:11 ` Dave Chinner
2011-10-10 11:23 ` Christoph Hellwig
2011-10-10 16:19 ` Sage Weil
2011-10-10 16:21 ` Christoph Hellwig
2011-10-11 15:39 ` Sage Weil
2011-10-11 21:56 ` Dave Chinner
2011-10-28 12:16 ` Christoph Hellwig
2011-10-28 17:02 ` Sage Weil
-- strict thread matches above, loose matches on Subject: below --
2011-07-08 21:10 Sage Weil
2011-07-26 23:24 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111009132155.GA5920@infradead.org \
--to=hch@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sage@newdream.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).