From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Sage Weil <sage@newdream.net>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, viro@ZenIV.linux.org.uk,
ceph-devel@vger.kernel.org, rwheeler@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: add d_prune dentry operation
Date: Mon, 10 Oct 2011 07:23:29 -0400 [thread overview]
Message-ID: <20111010112329.GB28627@infradead.org> (raw)
In-Reply-To: <20111010051141.GV3159@dastard>
On Mon, Oct 10, 2011 at 04:11:41PM +1100, Dave Chinner wrote:
> The code in the patch doesn't explain to me why you'd need to call
> dentry_lru_prune() rather than dentry_lru_del()? It's something to
> do with the difference between active and inactive LRU removal, but
Whenever we actually remove a object it needs to be removed, if it
only gets deleted from the LRU because it now has a reference and
doesn't belong onto the LRU it doesn't.
But yes, this really should be documented better in the code.
next prev parent reply other threads:[~2011-10-10 11:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 4:26 [PATCH] d_prune dentry_operation Sage Weil
2011-10-06 4:26 ` [PATCH] vfs: add d_prune dentry operation Sage Weil
2011-10-06 21:21 ` Christoph Hellwig
2011-10-06 22:20 ` Sage Weil
2011-10-09 13:21 ` Christoph Hellwig
2011-10-10 5:11 ` Dave Chinner
2011-10-10 11:23 ` Christoph Hellwig [this message]
2011-10-10 16:19 ` Sage Weil
2011-10-10 16:21 ` Christoph Hellwig
2011-10-11 15:39 ` Sage Weil
2011-10-11 21:56 ` Dave Chinner
2011-10-28 12:16 ` Christoph Hellwig
2011-10-28 17:02 ` Sage Weil
-- strict thread matches above, loose matches on Subject: below --
2011-07-08 21:10 Sage Weil
2011-07-26 23:24 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010112329.GB28627@infradead.org \
--to=hch@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sage@newdream.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).